Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blacklisting support for ROS 1 / Add options to continue despite errors / Allow to build to build stage #25

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Add blacklisting support for ROS 1 / Add options to continue despite errors / Allow to build to build stage #25

wants to merge 16 commits into from

Conversation

lreiher
Copy link
Member

@lreiher lreiher commented Jun 6, 2024 •
edited
Loading

  • adds blacklisting support for ROS 1
  • adds new config variables to continue despite errors
    • ENABLE_CONTINUE_BUILD_DESPITE_ERRORS: Enable catkin build --continue-on-failure / colcon build --continue-on-error
    • ENABLE_CONTINUE_ROSDEP_INSTALL_DESPITE_ERRORS: Enable rosdep install -r
  • allow to build up to build stage for devel space
    • build stage is where the source code has been built but source code is still present
    • if building in ROS 1 only works in devel, but not install space, the build stage is a good final image target
    • in order to build devel space, new config variable ENABLE_ROS1_DEVEL_SPACE is added

@lreiher lreiher requested a review from jpbusch June 6, 2024 13:54
@lreiher lreiher changed the title Add blacklisting support for ROS 1 / Add options to continue despite errors Add blacklisting support for ROS 1 / Add options to continue despite errors / Allow to build to build stage Jun 6, 2024
lreiher
lreiher commented Jun 6, 2024
View reviewed changes
README.md
Comment on lines +5 to +6
// TODO: explain build image somewhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: explain build image somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbusch jpbusch Awaiting requested review from jpbusch

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lreiher